search

igaster / laravel-theme

Theme support for Laravel
MIT License
516 stars 110 forks source link

Fix views-path override #73

Closed chocolatkey closed 7 months ago

chocolatkey commented 7 years ago

https://github.com/igaster/laravel-theme/blob/master/src/Themes.php#L194 defeats the purpose of setting "views-path" in a theme.json file. What if I want my views in directory/THEME/views instead of directory/THEME? Thanks to $data['views-path'] = $themeName; override, it doesn't matter what is set, so it would be a lot better if that were in the defaults instead.

danhunsaker commented 6 years ago

See also #68

ghost commented 5 years ago

@igaster are you planning to merge this fix?

igaster commented 4 years ago

Actually you can not set the views path inside theme.json, because theme.json is located inside the views!

Check comment: https://github.com/igaster/laravel-theme/blob/master/src/Themes.php#L210 I hope this makes sense!

The only way to change the views path is through config/themes.php