search

igd-geo / pasture

Rust library for point cloud processing
Apache License 2.0
72 stars 9 forks source link

Gpu Support #3

Closed kebiro closed 3 years ago

kebiro commented 3 years ago

Capability of uploading point buffer data onto the GPU and manipulating it via compute shaders. Download returns raw bytes for now. In device_compute.rs is an example that shows how the API is currently being used.

I put all of it behind a "gpu" feature flag. I hope I've done that right.

I've tried to include documentation although it may still be incomplete/lacking. I did not put example code in the docs since a lot of things are still subject to change, but I'll do it if you want me to do so.

Edit: should I squash my commits?

Mortano commented 3 years ago

Tests fail, possibly a different laz-rs version that broke something? Can't find anything in this PR that should affect the LAZ reader code. I have to investigate.

kebiro commented 3 years ago

Hey, sorry for the confusion. I never ran tests because I didn't write any, so I didn't notice I broke them. My bad.

I pulled your recent changes and tried to run it on my machine, and all tests pass in pasture-core and pasture-io. So I'm not sure where the error comes from.

Mortano commented 3 years ago

My best bet at the moment is that this is due to an upgrade of the las and laz crates. When I pull your branch into a clean repo, it installs las 0.7.5 even though 0.7.3 is specified. 0.7.5 uses the laz crate at version 0.6.0 internally, but pasture uses laz at version 0.5.2. So maybe something changed in between those versions, but I have to investigate further. For you, it probably works because you still have the older las version in your Cargo.lock