igdownloader / InstagramDownloader

Firefox and Chrome Extention which creates an download button for instagram images and videos and videos
https://huiibuh.github.io/InstagramDownloader/
780 stars 151 forks source link

Niclas.xml & niclas.xml on a case-insensitive file system giving git headaches #161

Closed marchage closed 3 years ago

marchage commented 3 years ago

Is your feature request related to a problem? Please describe. I was writing a bug report, but it's more a feature request I would say so I will past my original text here:

Hi,

Maybe I should post this at git or spend more time searching for ways to deal with this when it happens. But does it really need those 2 files, one of which is written with a capital "N"?

Important: Issues without the following information will be closed

To Reproduce Steps to reproduce the behaviour:

  1. Go to URL 'https://github.com/HuiiBuh/InstagramDownloader/'
  2. git clone
  3. git status

Expected behaviour A clear and concise description of what you expected to happen. nothing

Screenshots If applicable, add screenshots to help explain your problem.

Device (please complete the following information):

Additional context Concerns the following paths:

'.idea/dictionaries/Niclas.xml' '.idea/dictionaries/niclas.xml'

Side note/Unrelated As a side note, something which I am piggy-bagging in here but is unrelated: Nice setup! I loved it.

HuiiBuh commented 3 years ago

Hey. These files get auto generated by Intellij. So i don't intend to delete them.

The bulk download is intentionally async to improve the download speed. Perhaps it would be better to create a global http client which applies some kind of rate limiting and retries to avoid these 429 errors.

HuiiBuh commented 3 years ago

Edit I did not understand thr problem you were describing with the files. I will delete one of these files to the windows users the ability to clone thr extension without a problem

marchage commented 3 years ago

Oh okay, don't bother, Windows shouldn't have that issue. The important part is in bold :)

HuiiBuh commented 3 years ago

Haha thanks :) Glad you liked my setup