search

igentuman / NuclearCraft-Neoteric

This is a re-creation of old but gold NuclearCraft on a modern MC version
https://curseforge.com/minecraft/mc-mods/nuclearcraft-neoteric
MIT License
19 stars 13 forks source link

crash on world creation #100

Closed Xplodin closed 1 month ago

Xplodin commented 1 month ago

https://gist.github.com/Xplodin/027c517767458b1969762d9130922f4e

version: 1.19.2 - 43.3.9 - 1.0.4

MommyHeather commented 1 month ago

All registry names, resource locations etc need to be lowercase alphanumerical., with no spaces. Underscores are allowed, but other than that they HAVE to be lowercase alphanumerical.

So there's your fix igentuman

igentuman commented 1 month ago

All registry names, resource locations etc need to be lowercase alphanumerical., with no spaces. Underscores are allowed, but other than that they HAVE to be lowercase alphanumerical.

So there's your fix igentuman

yes i know. It should use item registry code, but for some reason it doesn't work. And i can't reproduce this issue.

igentuman commented 1 month ago

@Xplodin please checkout this build https://github.com/igentuman/NuclearCraft-Neoteric/actions/runs/9015489541

Xplodin commented 1 month ago

new crash: https://gist.github.com/Xplodin/577a00d8a01e88b305602ab1cfcd19d9

MommyHeather commented 1 month ago

Replace the colon with an underscore if you're copying registry names like that.

Though, why are you duplicating all the recipes like that?

Xplodin commented 1 month ago

Replace the colon with an underscore if you're copying registry names like that.

Though, why are you duplicating all the recipes like that?

I did add "alltheores" as a mod priority for ores into the materials.toml config if that helps or hinders anything. I put it as the first priority.

Am unsure if this is me at fault or not.

MommyHeather commented 1 month ago

I did add "alltheores" as a mod priority for ores into the materials.toml config if that helps or hinders anything. I put it as the first priority.

Am unsure if this is me at fault or not.

This is entirely an issue with the code, and not with anything you've done.

Neoteric is directly duplicating all furnace recipes as nuclear furnace recipes, the reason for which is unknown to me, and is doing it in a way that causes crashes.

igentuman commented 1 month ago

It's duplicating them on purpose. Nuclear Furnace will and can handle separate recipes. I will check this code

igentuman commented 1 month ago

https://github.com/igentuman/NuclearCraft-Neoteric/actions/runs/9043700720

blockgoblin31 commented 2 weeks ago

Can you upload the fixed version to curseforge? I'm getting this too in a pack I'm working on.(for 1.19.2)