search

igfuw / libcloudphxx

libcloudphysics++ - a library of algorithms for representing cloud microphysics in numerical models
http://libcloudphxx.igf.fuw.edu.pl/
Other
20 stars 20 forks source link

bug fix in term velocity #443

Closed claresinger closed 1 year ago

claresinger commented 1 year ago

Fixes a bug in terminal_vel_formulae for blk2m. was using diameter instead of radius to get size-dependent constants from Simmel et al (2002) table 2.

I was hoping this was the issue with precipitation flux (https://github.com/igfuw/UWLCM/pull/156), but it appears not to be the entire problem. One big clue is that only the rr_flux field is discontinuous, not the nr_flux so there must be some bug in v_term_m but not v_term_n or how these are applied.

term_vel_fix.pdf

claresinger commented 1 year ago

Many thanks to @trontrytel for helping me fix the integrals finally this morning! @pdziekan This PR should also let us merge https://github.com/igfuw/UWLCM/pull/156

image

claresinger commented 1 year ago

@pdziekan I guess I need to update the kinematic2D refdata for blk2m. I'll do that now :)

claresinger commented 1 year ago

@pdziekan can you re-run the tests now? Do you know why they don't run automatically or there isn't a button where I can trigger them?

pdziekan commented 1 year ago

I think that only repo admins can trigger tests.

pdziekan commented 1 year ago

Many thanks @claresinger !