Fix Example and Add Support for Connection String

iggy-rs / iggy-python-client

Official Python client SDK for Iggy.rs message streaming.

https://pypi.org/project/iggy-py/

MIT License

18 stars 7 forks source link

Fix Example and Add Support for Connection String #24

Closed lsabi closed 1 month ago

lsabi commented 1 month ago

Add support for Connection String #https://github.com/iggy-rs/iggy-python-client/issues/22
Simplify client to support stream and topic names instead of ids
Fix examples according to changes

spetz commented 1 month ago

Thank you for the contribution, LGTM :)

lsabi commented 1 month ago

@spetz You're welcome. Two notes though:

I thought that it's more pythonic to have functions like create_stream("sample-stream") create_topic("stream-name", "topic-name"). Maybe I could add a more "low level" layer that uses also IDs
Do you mind testing it? I've tested on my local, but then copied and pasted the edits on the online editor. Hope I didn't mess it up...

spetz commented 1 month ago

@lsabi would you mind joining our Discord? I'm not a Python dev myself, so hopefully the other members could be more helpful. On my side, I'm open to any suggestions that you have :)

mmodzelewski commented 1 month ago

Do you mind testing it? I've tested on my local, but then copied and pasted the edits on the online editor. Hope I didn't mess it up...

@lsabi Please let me know once the PR is ready, I'll be able to test it.

lsabi commented 1 month ago

@mmodzelewski does it work on your computer?

I was still testing this code, since I found a problem with the Identifier parameter of create_topic, send_messages and poll_messages...it seems that it changes the ID on every new connection. Or it doesn't associate the name with the id, resulting in topics with the same name, but different ID.

mmodzelewski commented 1 month ago

@lsabi yes, it worked fine, so I merged it. If I try to create a stream or topic with the same name, I get an error, so that looks good. I'll do some more testing later today, but if you have any specific use case that you would like me to try out, let me know.

lsabi commented 1 month ago

@mmodzelewski now it seems to be working on my computer as well.

Well enough, it could be deployed to the public package registry....am I supposed to change the version from 0.2.4 to 0.2.5? If so, where exactly? I've never worked with PyO3

mmodzelewski commented 1 month ago

@lsabi great to hear that it works for you as well :) I'll add another small change and will push a new version, probably tomorrow.