search

iggy-rs / iggy-python-client

Official Python client SDK for Iggy.rs message streaming.
https://pypi.org/project/iggy-py/
MIT License
18 stars 7 forks source link

:sparkles: Add timestamp, id and checksum info for a received message #32

Open lsabi opened 3 weeks ago

lsabi commented 3 weeks ago

Add metadata for received message.

I'm not sure if it makes sense to also add:

I think that for now, timestamp and id are the most important, especially if we consider the implementation of the Pollingstrategy with the timestamp (which I'm trying to use). Since checksum is also a primitive data type, I've also added it (why not?)

mmodzelewski commented 3 weeks ago

I'm not sure if it makes sense to also add:

  • MessageState
  • Headers
  • Length

The end goal would be to have full capabilities of the underlying SDK, so I'd say we should include these eventually.

lsabi commented 3 weeks ago

@mmodzelewski I've fixed the checksum's return and added also the remaining information, but the headers which I don't know what is a good way of representing them. Maybe a dict? If you have any suggestions, let me know or feel free to edit and then merge the branch.

mmodzelewski commented 2 weeks ago

I think dict would be good for headers, but it will require more work as it can hold different types of data. We can leave it for another PR.

lsabi commented 5 days ago

@mmodzelewski did you get a chance to look at the PR?