search

iggyfisk / highperch

highper.ch official web
2 stars 1 forks source link

Map parsing fails on two Blizz maps #67

Open tylerkerr opened 4 years ago

tylerkerr commented 4 years ago 
Map failed: C:/Users/tkerr/Documents/Warcraft III Beta/Maps/to-parse/(6)JungleFever.w3x
Map failed: C:/Users/tkerr/Documents/Warcraft III Beta/Maps/to-parse/(6)RiceFields.w3x

It failed on a bunch of others too, originally:

Map failed: C:/Users/tkerr/Documents/Warcraft III Beta/Maps/to-parse/(2)Justice.w3x
Map failed: C:/Users/tkerr/Documents/Warcraft III Beta/Maps/to-parse/(2)MeltingValley.w3x
Map failed: C:/Users/tkerr/Documents/Warcraft III Beta/Maps/to-parse/(2)SecretValley.w3x
Map failed: C:/Users/tkerr/Documents/Warcraft III Beta/Maps/to-parse/(4)BrutalWinter.w3x
Map failed: C:/Users/tkerr/Documents/Warcraft III Beta/Maps/to-parse/(4)Deadfall.w3x

but using the Reforged worldedit to open and re-save them appears to have solved the issue. This is probably extremely unimportant unless Rice Fields gets put back in the rotation

tylerkerr commented 4 years ago

Parsing also fails on (4)TranquilPaths.w3m (a ROC map), even if I open it in Reforged worldedit and resave it as a TFT (w3x) map. I tried it with (8)TheCrucible.w3m too. Makes me think these failures are specific issues with the mapfile content that wc3maptranslator can't handle

tylerkerr commented 4 years ago

The failures on Jungle Fever and Rice Fields are due to random unit tables, which are marked as unsupported by WC3MapTranslator. Might be fixable

tylerkerr commented 4 years ago

Another parser failure: custom item drop tables in WC3MapTranslator's InfoTranslator.js are disabled and marked as unsupported. Might also be fixable by us, but only one map in the current rotation is affected: (4)FurbolgMountain.w3x. Leaving it alone for now