search

igihcksn / mypocketmonsters

https://mypocketmonsters.vercel.app
1 stars 15 forks source link

Fix for layout on trainer info page #27

Open narayand16 opened 2 years ago

narayand16 commented 2 years ago

Hi @igihcksn I have reduced the image width and added some extra info about trainer. Here is the screenshot. Fix for #15

image

Also added prettier for formatting, so you might be seeing indented code in the file.

Regarding the navigation , I feel it is fine. I was thinking to keep it fixed at top but then we need to keep the header (Pikachu image and info) to be fixed as well. If we do so, half of the page will only be available for the user to scroll which might give bad user experience.

Let me know in case of anything.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/igihcksn1/mypocketmonsters/DqHAByNPH8Y99swbt8wX3LFxK5vZ
✅ Preview: https://mypocketmonsters-git-fork-narayand16-fix-layou-ce3395-igihcksn1.vercel.app

narayand16 commented 2 years ago

@igihcksn Did you get chance to go through this PR ? Would love to know your thoughts, if any.