iglee42 / CreateCasing

An addon of The Create Mod who makes Shaft/Cogwheels/Pipe encasable with all casings
http://iglee.fr
MIT License
6 stars 13 forks source link

[Bug] Crashing when pondering a fluid pipe. #83

Closed talu-mmvi closed 2 months ago

talu-mmvi commented 2 months ago

The game crashes in the middle of pondering of a fluid pipe when the mechanical pipe is about to appear.

And here's a crash log: https://mclo.gs/AwA3xRG

iglee42 commented 2 months ago

I think it's crash from create because Create Encased don't modify fluid pipe code

talu-mmvi commented 2 months ago

i did test it with vanilla create and there was no issue

talu-mmvi commented 2 months ago

and also cogwheels are appearing with a mechanical pump

iglee42 commented 2 months ago

I don't understand where the crash could come from

omgimanerd commented 2 months ago

+1 to this issue. I replicated it with

Minecraft version: 1.20.1 Forge loader: 47.3.0 Create: 0.5.1f Create Encased: 1.20.1-1.6.1

The culprit line here:

com.google.common.util.concurrent.UncheckedExecutionException: java.lang.IllegalArgumentException: Cannot get property BooleanProperty{name=down, clazz=class java.lang.Boolean, values=[true, false]} as it does not exist in Block{create:mechanical_pump}

seems to indicate that a property of the mechanical pump is causing the crash. If I were to guess, it's because mechanical pumps call some of the cogwheel code (since they have a cogwheel)?

iglee42 commented 2 months ago

Fixed in the next update

omgimanerd commented 1 month ago

Will this bugfix be released on CF for version 1.20.1? Or only future versions?

iglee42 commented 1 month ago

It will be released for 1.18.2/1.19.2/1.20.1

iglee42 commented 1 month ago

Update pushed on curseforge : https://create-encased.iglee.fr