saharg
commented
6 years ago Good catch, have you fixed it or should I?
From: Stephen Eglen notifications@github.com Reply-To: igm-team/meaRtools reply@reply.github.com Date: Thursday, June 14, 2018 at 06:12 To: igm-team/meaRtools meaRtools@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [igm-team/meaRtools] . in function names should be _ (#43)
just noticed, in the examples, we have them in \dontrun{} which is good, but function should be with _ not . https://github.com/igm-team/meaRtools/blob/21bb8e7e6181bb99d4cf6d0b16db7e38fb4ed868/meaRtools/man/plot_plate_summary_for_spikes.Rd#L36https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_igm-2Dteam_meaRtools_blob_21bb8e7e6181bb99d4cf6d0b16db7e38fb4ed868_meaRtools_man_plot-5Fplate-5Fsummary-5Ffor-5Fspikes.Rd-23L36&d=DwMCaQ&c=G2MiLlal7SXE3PeSnG8W6_JBU6FcdVjSsBSbw6gcR0U&r=ge_R2T3Y058K_3mByM2dzKz_DKjxQ6JNBYLU38IGXk8&m=tOzdoYquqfZ7zaOAIFY3K9RqboRq3qtKb6NmF-WoDIw&s=ngSufEw_OoM7jOiuk9ibto74aUskih89R4usovCCO00&e=
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_igm-2Dteam_meaRtools_issues_43&d=DwMCaQ&c=G2MiLlal7SXE3PeSnG8W6_JBU6FcdVjSsBSbw6gcR0U&r=ge_R2T3Y058K_3mByM2dzKz_DKjxQ6JNBYLU38IGXk8&m=tOzdoYquqfZ7zaOAIFY3K9RqboRq3qtKb6NmF-WoDIw&s=gouoEdnCawY8xRURKV2RBWYfXz4Oykhy2RKAXjo53B8&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ANC9uEAum4clAjcBehlGm3AtJAPztbRZks5t8jcJgaJpZM4Unrs7&d=DwMCaQ&c=G2MiLlal7SXE3PeSnG8W6_JBU6FcdVjSsBSbw6gcR0U&r=ge_R2T3Y058K_3mByM2dzKz_DKjxQ6JNBYLU38IGXk8&m=tOzdoYquqfZ7zaOAIFY3K9RqboRq3qtKb6NmF-WoDIw&s=SAIKU6Z3qs7OQ9te4bzVznA9sOysB93Ou-7DelepJyM&e=.
sje30
just noticed, in the examples, we have them in \dontrun{} which is good, but function should be with _ not . https://github.com/igm-team/meaRtools/blob/21bb8e7e6181bb99d4cf6d0b16db7e38fb4ed868/meaRtools/man/plot_plate_summary_for_spikes.Rd#L36