search

igmhub / LaCE

Emulator for the one-dimensional Lyman-alpha flux power spectrum. It was used to generate the results shown in https://arxiv.org/abs/2011.15127, https://arxiv.org/abs/2209.09895, and https://arxiv.org/abs/2305.19064.
1 stars 3 forks source link

Multiple changes to archive and emulator classes #25

Closed andreufont closed 1 year ago

andreufont commented 1 year ago

Several week long discussion on archives, training sets, emulators, and more.

We are not yet 100% happy with the situation, but it is good enough for now, and we will come back to this after the DESI meeting

andreufont commented 1 year ago

I would like to review them a bit more closely next week, but we'll try to merge soon

andreufont commented 1 year ago

I added several comments related to obsolete files, and some confusion around the ThermalModel object from cup1d.

Besides these, I'm now trying to reproduce old forecasts with cup1d when using the new LaCE archive / emulator objects, once these are confirmed I'll be happy to merge.

andreufont commented 1 year ago

new_cup1d

Yaaaaaay :-)

andreufont commented 1 year ago

@lauracabayol - I've done several minor changes to address my own comments during my review. Could you check for the last time that I have not broken anything?

I would then proceed with the merge.