search

igmhub / LaCE

Emulator for the one-dimensional Lyman-alpha flux power spectrum. It was used to generate the results shown in https://arxiv.org/abs/2011.15127, https://arxiv.org/abs/2209.09895, and https://arxiv.org/abs/2305.19064.
1 stars 3 forks source link

Changes in the tutorial for the Durham meeting #28

Closed andreufont closed 1 year ago

andreufont commented 1 year ago

Several changes in the notebook, and a minor change in the code

andreufont commented 1 year ago

Yes, sorry, we should clarify this in the notebook, and explain how to find the Nyx file at NERSC.

Those that do not have the Nyx file can still run the notebook, without the Nyx emulator

On Fri, Jul 14, 2023 at 11:44 AM Jonás Chaves-Montero < @.***> wrote:

@.**** commented on this pull request.

On notebooks/Durham2023_LaCETutorial.ipynb https://github.com/igmhub/LaCE/pull/28#discussion_r1263530476:

I get this error for Nyx

ValueError: Define NYX_PATH variable or pass file_name

is this now expected?

— Reply to this email directly, view it on GitHub https://github.com/igmhub/LaCE/pull/28#discussion_r1263530476, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5RYR7I2GM36LWCGSUKG5DXQEIIDANCNFSM6AAAAAA2KB3U7A . You are receiving this because you authored the thread.Message ID: @.***>

-- Avís - Aviso - Legal Notice - (LOPD) - http://legal.ifae.es http://legal.ifae.es/

andreufont commented 1 year ago

I made some changes to call CAMB fewer times, so I'm not sure what dominates the time of reading Nyx archive. It would be good to speed it up, but what you mention here is that the training itself also takes time. This is because the settings in Cabayol23_Nyx is quite strict (many epochs, many steps). We could use simpler settings in the notebook, I can take care of this. The performance will be degraded, but this is ok.

On Fri, Jul 14, 2023 at 11:48 AM Jonás Chaves-Montero < @.***> wrote:

@.**** commented on this pull request.

On notebooks/Durham2023_LaCETutorial.ipynb https://github.com/igmhub/LaCE/pull/28#discussion_r1263533882:

I also find that training the NN emulators takes too long for a tutorial. I can also work today on improving the speed of reading data

— Reply to this email directly, view it on GitHub https://github.com/igmhub/LaCE/pull/28#discussion_r1263533882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5RYRZWII4IH6KMNSTXZITXQEIV3ANCNFSM6AAAAAA2KB3U7A . You are receiving this because you authored the thread.Message ID: @.***>

-- Avís - Aviso - Legal Notice - (LOPD) - http://legal.ifae.es http://legal.ifae.es/

jchavesmontero commented 1 year ago

The notebook looks great! Everything else goes smoothly, great work!

andreufont commented 1 year ago

@jchavesmontero - could you approve the PR then?