igmhub / LaCE

Emulator for the one-dimensional Lyman-alpha flux power spectrum. It was used to generate the results shown in https://arxiv.org/abs/2011.15127, https://arxiv.org/abs/2209.09895, and https://arxiv.org/abs/2305.19064.
1 stars 3 forks source link

Seperate lin p fit #44

Closed schoeneberg closed 1 year ago

schoeneberg commented 1 year ago

Seperated the fit_linP from the get_linP, so that the conversion into Delta2_p and n_p can be done independently of CAMB, if one provides a full list of k values and P(k) values!

andreufont commented 1 year ago

@jchavesmontero - could you take a look at the PR by Nils? If we split this function in two, then he can call the function to fit linP params from a (k, Pk) tuple, and then he can use that from MontePython / CLASS without needing CAMB there either.

andreufont commented 1 year ago

It's a one-file PR, but I have to attend a call now. Otherwise I'll do it tomorrow.

andreufont commented 1 year ago

I think we are good to go, I've tested that both LaCE notebooks and cup1d notebooks run on my laptop and at NERSC

jchavesmontero commented 1 year ago

@jchavesmontero - could you take a look at the PR by Nils? If we split this function in two, then he can call the function to fit linP params from a (k, Pk) tuple, and then he can use that from MontePython / CLASS without needing CAMB there either.

Looks good!