search

igmhub / LaCE

Emulator for the one-dimensional Lyman-alpha flux power spectrum. It was used to generate the results shown in https://arxiv.org/abs/2011.15127, https://arxiv.org/abs/2209.09895, and https://arxiv.org/abs/2305.19064.
1 stars 3 forks source link

Solving issues #41 and #42 #45

Closed jchavesmontero closed 1 year ago

jchavesmontero commented 1 year ago

This pull request addressed issues #41 and #42. I can run the notebook and emulator bookkeeping, and it would be great to check whether cup1d breaks or not after this commit.

jchavesmontero commented 1 year ago

@jchavesmontero - most of the changes look good, but I don't understand why update_kp should now be passed in the archive constructors.

I will now test the code on my laptop and desktop

You only need to pass update_kp to recompute the results for the fiducial value (0.7), for any other value you do not need to pass it

andreufont commented 1 year ago

I understand now force_recompute_linP_params, this is useful for the script. Thanks!