search

igmhub / LaCE

Emulator for the one-dimensional Lyman-alpha flux power spectrum. It was used to generate the results shown in https://arxiv.org/abs/2011.15127, https://arxiv.org/abs/2209.09895, and https://arxiv.org/abs/2305.19064.
1 stars 3 forks source link

got rid of obsolete options in LaCE (use_camb_fz and include_f_p) #5

Closed andreufont closed 1 year ago

andreufont commented 1 year ago

@jchavesmontero - let's not merge yet, since it might crash other codes (LaCE_manager, cup1d, etc.), but it would be good to get rid of these old options that are obsolete now. I'd like to slowly clean up old code that is not needed in LaCe.

jchavesmontero commented 1 year ago

Sure!

jchavesmontero commented 1 year ago

I would be surprised if anything breaks though, that camb_kmax_Mpc was only used in get_camb_results and I kept the same default value as before

andreufont commented 1 year ago

I've listed both @jchavesmontero and @lauracabayol as reviewers, mainly as a way of testing the workflow. One review should be enough though.

andreufont commented 1 year ago

@lauracabayol - this is the PR I just mention on the call. Please take a look at the "files changed" above, browse them, and add any comment you might have. Once you are happy you can "approve" the PR.

lauracabayol commented 1 year ago

Everything looks good for me