igmhub / LaCE

Emulator for the one-dimensional Lyman-alpha flux power spectrum. It was used to generate the results shown in https://arxiv.org/abs/2011.15127, https://arxiv.org/abs/2209.09895, and https://arxiv.org/abs/2305.19064.
1 stars 3 forks source link

Include nyx_version flag in bookkeeper #54

Closed jchavesmontero closed 1 year ago

jchavesmontero commented 1 year ago

Include this flag for consistency with future versions of the Nyx file. Could you first run src/lace/scripts/compute_nyx_emu_cosmo.py and then Tutorial_bookkeeping.ipynb?

If it works, I will update the readme as well

andreufont commented 1 year ago

Could you take care of this

andreufont commented 1 year ago

Sorry, wrong button...

I noticed that this is a "draft" pull request?

jchavesmontero commented 1 year ago

Yes, I made a draft because I wanted to check that it worked. I am assuming it does, so before any push, I wanted to update the readme. Let me do it and I will turn it into a real PR

andreufont commented 1 year ago

@lauracabayol - could you take care of the review? Otherwise I'll do it on Monday

jchavesmontero commented 1 year ago

I have already updated the readme, waiting for your review

andreufont commented 1 year ago

@lauracabayol this one

lauracabayol commented 1 year ago

It is raising an error related with the NYX_PATH: (DESIenv6) [lcabayol@tdm003 LaCE]$ python src/lace/scripts/compute_nyx_emu_cosmo.py Traceback (most recent call last): File "/nfs/pic.es/user/l/lcabayol/DESI/LaCE/src/lace/scripts/compute_nyx_emu_cosmo.py", line 72, in main() File "/nfs/pic.es/user/l/lcabayol/DESI/LaCE/src/lace/scripts/compute_nyx_emu_cosmo.py", line 16, in main nyx_fname = os.environ["NYX_PATH"] + "modelsNyx" + nyx_version + ".hdf5" File "/data/astro/scratch/lcabayol/anaconda3/envs/DESIenv6/lib/python3.10/os.py", line 680, in getitem raise KeyError(key) from None KeyError: 'NYX_PATH'

lauracabayol commented 1 year ago

Everything working smoothly after addting the Nyx_path as environment variable

jchavesmontero commented 1 year ago

Thanks a lot @lauracabayol!