igmhub / picca

set of tools for continuum fitting, correlation function calculation, cosmological fits...
GNU General Public License v3.0
30 stars 22 forks source link

Dependency issues when installing Picca #1027

Closed m-herbold closed 1 year ago

m-herbold commented 1 year ago

There is a depreciation error, no longer a warning, when running some Picca functions since np.int is no longer supported in new versions of numba.

When pip installing picca to a conda environment, some packages (like numba) automatically install a newer version (e.g., 0.57), which causes errors, so you have to manually downgrade some of the packages (e.g., numba=0.55.1) to match the requirements.txt file.

p-slash commented 1 year ago

Hi Meagan, can you also provide the exact error output you encounter? It sounds like the error is numba does not support np.int within njit

m-herbold commented 1 year ago

Here is a test conda environment using "pip install picca." The versions for some of the packages are higher than those in the requirement.txt file.

image

The main one that I have seen issues with is numba, namely the np.int that you mentioned. It causes issues with some of the code like "picca_cf.py,"

image

Waelthus commented 1 year ago

From the error msg you seem to be using picca v6.1.0 which indeed has those issues. But we did have a fix in PR #1002 (part of v7.0.0 and later)...

The master branch is tested against numpy 1.24.4 and numba 0.57.1 at the moment. Those tests generally use decently recent versions of libraries, but we don't always change the requirements.txt file, only if newer versions break the tests and break backwards compatibility this is really necessary. The tests run fine with those and you can use those newer package versions.

A simple pip install picca should now pick up v7.0.1 from yesterday.

If you really need to run v6.1.0 you'll need to downgrade your numpy and numba to lower version numbers, e.g. the ones in requirements.txt.

iprafols commented 1 year ago

We'll close the issue provisionally, but please re-open it and let us know if you're still seeing this problem in version 7.x