search

igmhub / picca

set of tools for continuum fitting, correlation function calculation, cosmological fits...
GNU General Public License v3.0
30 stars 22 forks source link

[bump minor] Add new FVoigt script #1037

Open andreicuceu opened 11 months ago

andreicuceu commented 11 months ago

A simplified version of the FVoigt computation, based on the code by @moonlovist. Work in progress.

Waelthus commented 11 months ago

also: please add docstrings and ideally a test...

iprafols commented 10 months ago

is this ready for review?

andreicuceu commented 10 months ago

Yes, this has been tested and working for a while now.

iprafols commented 8 months ago

Hi all, I modified the file so that it now uses functions already defined in dla_mask, instead of defining new functions that do the same things. @andreicuceu can you check that I did not accidentally add a normalisation issue?

iprafols commented 8 months ago

I fixed the typo and added the lyman beta absorption, but tests are still missing

iprafols commented 8 months ago

tests are failing due to a weird coveralls error. Maybe their server is down. Otherwise, they might have updated something and the new version is not backwards compatible. We should try to rerun failing tests in a while to see if it was just their server being down or not

Waelthus commented 7 months ago

somewhere things are going wrong, here: grafik expected: grafik