igmhub / picca

set of tools for continuum fitting, correlation function calculation, cosmological fits...
GNU General Public License v3.0
29 stars 22 forks source link

Redshifts in metal matrices [bump minor] #1045

Closed julienguy closed 11 months ago

julienguy commented 11 months ago

Record in the metal matrices the weighted mean redshift of the input to the remapping matrix (i.e. the true absorber redshift) and not the output of the remapping (the 'incorrect' Lya redshift). Both redshifts (input and output) could be useful, but for the purpose of interpreting correctly the metal biases coming from a fit using the metal matrices, the metal redshifts are obviously the correct ones to use. This is what was done in the previous code, so we are fixing here an inconsistency.

This PR addresses issue #1044 .

andreufont commented 11 months ago

@iprafols - this looks like a trivial bug fix, and it would be great to have it included in a new tagged version. Thanks!