Fix and update BAL wavelengths for LyB region

igmhub / picca

set of tools for continuum fitting, correlation function calculation, cosmological fits...

GNU General Public License v3.0

29 stars 22 forks source link

Fix and update BAL wavelengths for LyB region #1047

Closed paulmartini closed 9 months ago

paulmartini commented 11 months ago

The list of BAL lines in bal_mask.py has the wrong wavelength for LyB (1020 vs. the correct value of 1025.7). For a "LyB region" that extends to rest frame 920A, we should also mask some of the other Lyman lines. I'd at least add 972.5 and 949.7. A few other strong BAL features NIII 989.9 and CIII 977.0.

iprafols commented 11 months ago

Hi Paul, not sure why I can't appoint you as a reviewer, but I created a PR (#1048 ) fixing this. Can you please review it and confirm that the changes are indeed fixing this issue?

paulmartini commented 9 months ago

Hi @iprafols -- Can we close this issue based on PR1048? Just noticed it is still open.

iprafols commented 9 months ago

Sure. I thought we had already closed it