search

igmhub / picca

set of tools for continuum fitting, correlation function calculation, cosmological fits...
GNU General Public License v3.0
29 stars 22 forks source link

Remove print message of H0 in picca_xcf #948

Open andreufont opened 1 year ago

andreufont commented 1 year ago

I just noticed a message of H0=100, what is at least confusing. I believe H0 is not used in picca_xcf, but if we use it we should use a more standard value.

iprafols commented 1 year ago

See the comments in PR #971. The value of H0 should be 100 since we are computing things in Mpc/h, so yes, I think we should remove the print to avoid confusion

andreufont commented 1 year ago

This is all very confusing. I thought we were using the same default cosmo in all DESI papers! I don't see why would Picca ever use H_0=100 as default, regardless of the units we use (km/s, Mpc or Mpc/h). Ignasi, maybe you and Calum can explain this to me in person?

On Wed, 19 Apr 2023, 10:57 Ignasi Pérez-Ràfols, @.***> wrote:

See the comments in PR #971 https://github.com/igmhub/picca/pull/971. The value of H0 should be 100 since we are computing things in Mpc/h, so yes, I think we should remove the print to avoid confusion

— Reply to this email directly, view it on GitHub https://github.com/igmhub/picca/issues/948#issuecomment-1514376211, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5RYRYWPCIL6XFSSGOF3Z3XB6SJJANCNFSM6AAAAAATEKBZBQ . You are receiving this because you authored the thread.Message ID: @.***>

-- Avís - Aviso - Legal Notice - (LOPD) - http://legal.ifae.es http://legal.ifae.es/

andreufont commented 1 year ago

To clarify my comment: when computing pixel pair separations from angles / redshifts in picca_cf you don't need to use H_0, the only thing that matters is Omega_m (in a flat LCDM, otherwise you also need Omega_k or Omega_Lambda). Unless if you compute the correlations in Mpc, buy that's a different discussion.

You need to specify other cosmological parameters at the fitting level, but I believe this is not what you are discussing now.

Andreu

On Wed, 19 Apr 2023, 11:21 Andreu Font Ribera, @.***> wrote:

This is all very confusing. I thought we were using the same default cosmo in all DESI papers! I don't see why would Picca ever use H_0=100 as default, regardless of the units we use (km/s, Mpc or Mpc/h). Ignasi, maybe you and Calum can explain this to me in person?

On Wed, 19 Apr 2023, 10:57 Ignasi Pérez-Ràfols, @.***> wrote:

See the comments in PR #971 https://github.com/igmhub/picca/pull/971. The value of H0 should be 100 since we are computing things in Mpc/h, so yes, I think we should remove the print to avoid confusion

— Reply to this email directly, view it on GitHub https://github.com/igmhub/picca/issues/948#issuecomment-1514376211, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5RYRYWPCIL6XFSSGOF3Z3XB6SJJANCNFSM6AAAAAATEKBZBQ . You are receiving this because you authored the thread.Message ID: @.***>

-- Avís - Aviso - Legal Notice - (LOPD) - http://legal.ifae.es http://legal.ifae.es/