igmhub / picca

set of tools for continuum fitting, correlation function calculation, cosmological fits...
GNU General Public License v3.0
29 stars 22 forks source link

Pk1d zchunks #968

Closed armengau closed 1 year ago

armengau commented 1 year ago

New option in pk1d_postprocess: --apply_z_weights (default False). If set, each FFT chunck at redshift z contributes 2 nearby z bins, with a triangle-shape weight function identical to that used by the QMLE. Tests with the fujilupe mocks show the impact on the measured P1D is less than 1%.

iprafols commented 1 year ago

The changes look fine. I have spotted a couple of lines that potentially will need changes. @armengau can you review them? Otherwise, I think the PR is ready to merge

armengau commented 1 year ago

I think it's ok now