igmhub / picca

set of tools for continuum fitting, correlation function calculation, cosmological fits...
GNU General Public License v3.0
29 stars 22 forks source link

astronomical object uses rad as units (not deg) #983

Closed cramirezpe closed 1 year ago

cramirezpe commented 1 year ago

I've checked and the only difference in the delta files are the units:

 fitsdiff: 5.2.1
 a: results/delta_extraction_lin_image/Delta/delta-1.fits.gz
 b: data/delta_extraction_lin_image/Delta/delta-1.fits.gz
 Maximum number of different data values to be reported: 10
 Relative tolerance: 0.01, Absolute tolerance: 0.0

Extension HDU 1 (LAMBDA, 1):

   Headers contain differences:
     Keyword CHECKSUM has different values:
        a> bEepc9enbCenb9en
        b> dFiqd9fndCfnd9fn
     Keyword CHECKSUM has different comments:
        a> HDU checksum updated 2023-04-26T12:17:56
         ?                            ^ ^^  ^  ^^^^
        b> HDU checksum updated 2023-03-15T13:35:14
         ?                            ^ ^^  ^^^^  ^
     Keyword DATASUM  has different comments:
        a> data unit checksum updated 2023-04-26T12:17:56
         ?                                  ^ ^^  ^  ^^^^
        b> data unit checksum updated 2023-03-15T13:35:14
         ?                                  ^ ^^  ^^^^  ^

Extension HDU 2 (METADATA, 1):

   Headers contain differences:
     Keyword CHECKSUM has different values:
        a> 8GSg8DRe8DRe8DRe
        b> 9CThJCRe9CReGCRe
     Keyword CHECKSUM has different comments:
        a> HDU checksum updated 2023-04-26T12:17:56
         ?                            ^ ^^  ^  ^^^^
        b> HDU checksum updated 2023-03-15T13:35:14
         ?                            ^ ^^  ^^^^  ^
     Keyword DATASUM  has different comments:
        a> data unit checksum updated 2023-04-26T12:17:56
         ?                                  ^ ^^  ^  ^^^^
        b> data unit checksum updated 2023-03-15T13:35:14
         ?                                  ^ ^^  ^^^^  ^
     Keyword TUNIT2   has different values:
        a> rad
        b> deg
     Keyword TUNIT3   has different values:
        a> rad
        b> deg

   Data contains differences:
     Column DEC has different units:
        a> rad
        b> deg
     Column RA has different units:
        a> rad
        b> deg

Extension HDU 3 (DELTA, 1):

   Headers contain differences:
     Keyword CHECKSUM has different values:
        a> ZadVcZZSZabSbWZS
        b> 9cQaGZQR9bQXEZQX
     Keyword CHECKSUM has different comments:
        a> HDU checksum updated 2023-04-26T12:17:56
         ?                            ^ ^^  ^  ^^^^
        b> HDU checksum updated 2023-03-15T13:35:14
         ?                            ^ ^^  ^^^^  ^
     Keyword DATASUM  has different values:
        a> 2052636157
        b> 2023335554
     Keyword DATASUM  has different comments:
        a> data unit checksum updated 2023-04-26T12:17:56
         ?                                  ^ ^^  ^  ^^^^
        b> data unit checksum updated 2023-03-15T13:35:14
         ?                                  ^ ^^  ^^^^  ^

Extension HDU 4 (WEIGHT, 1):

   Headers contain differences:
     Keyword CHECKSUM has different values:
        a> Xee2Yce0Xce0Xce0
        b> Ra4NSU4KRa4KRU4K
     Keyword CHECKSUM has different comments:
        a> HDU checksum updated 2023-04-26T12:17:56
         ?                            ^ ^^  ^  ^^^^
        b> HDU checksum updated 2023-03-15T13:35:14
         ?                            ^ ^^  ^^^^  ^
     Keyword DATASUM  has different values:
        a> 3237017340
        b> 3636236056
     Keyword DATASUM  has different comments:
        a> data unit checksum updated 2023-04-26T12:17:56
         ?                                  ^ ^^  ^  ^^^^
        b> data unit checksum updated 2023-03-15T13:35:14
         ?                                  ^ ^^  ^^^^  ^

Extension HDU 5 (CONT, 1):

   Headers contain differences:
     Keyword CHECKSUM has different values:
        a> hMWWiJTWhJTWhJTW
        b> LHVIOGVFLGVFLGVF
     Keyword CHECKSUM has different comments:
        a> HDU checksum updated 2023-04-26T12:17:56
         ?                            ^ ^^  ^  ^^^^
        b> HDU checksum updated 2023-03-15T13:35:14
         ?                            ^ ^^  ^^^^  ^
     Keyword DATASUM  has different values:
        a> 3629877370
        b> 3764243699
     Keyword DATASUM  has different comments:
        a> data unit checksum updated 2023-04-26T12:17:56
         ?                                  ^ ^^  ^  ^^^^
        b> data unit checksum updated 2023-03-15T13:35:14
         ?                                  ^ ^^  ^^^^  ^

I think this is safe to be replaced and merged.