search

ignacio-chiazzo / Algorithms-Leetcode-Javascript

Algorithms resolution in Javascript. Leetcode - Geeksforgeeks - Careercup
https://ignacio-chiazzo.github.io/Algorithms-Leetcode-Javascript/
MIT License
608 stars 88 forks source link

Add the option to run lint and unit test locally. #65

Closed ignacio-chiazzo closed 1 year ago

ignacio-chiazzo commented 2 years ago

The current repository uses a Github Action for running linters Github workflows

Add the option to run the linter locally by running commands. Optionally we can combine unit tests and lint and run them all in one command. There are also a few tests failing that should be updated.

hot9cups commented 2 years ago

As a first step, all the existing lint errors have been fixed, and the failing tests have been updated. These changes can be found in the following PR - https://github.com/ignacio-chiazzo/Algorithms-Leetcode-Javascript/pull/67

hot9cups commented 1 year ago

I see that

  1. 67 fixed the failing tests and linting errors.

  2. 76 has the unit tests enhanced, node Tests.js enables running unit tests locally.

  3. 70 enables running linter and automatic fixing locally via eslint --fix.

Once #76 is merged, I think we should be good to close this issue?

ignacio-chiazzo commented 1 year ago

Thanks for the amazing work on this @hot9cups!