ignacio-rocco / weakalign

End-to-end weakly-supervised semantic alignment
MIT License
209 stars 47 forks source link

Question for inliers score #8

Open codeslake opened 6 years ago

codeslake commented 6 years ago

https://github.com/ignacio-rocco/weakalign/blob/52505eaeed52dc82cf755919b119ef99fe8b1ed1/train_weak.py#L126

Hi, First, thank you for sharing your work.

For the line of code attached, why are you passing "corr_aff" for the match? Shouldn't it be "corr_aff_tps"?

"mask_id" in the loss computation code goes through transformation up to tps. Wouldn't it be more appropriate to masking it with "corr_aff_tps"?

Thanks.