ignasxvv / master-of-education

Interactive learning Project based on Reactino (Arduino-serial, React and NodeJS)
https://react-master-of-education1.vercel.app/
1 stars 1 forks source link

Extract each lesson into a separate file #39

Closed ignasxvv closed 3 months ago

ignasxvv commented 3 months ago

Let's have three folders under lessons, And each lesson stands in its own .tsx file

Heracraft commented 3 months ago

simply why? we'll import the components the same way so why?

ignasxvv commented 3 months ago

simply why? we'll import the components the same way so why?

It's a good convention to separate Objects (in this case components) into their own separate files -at least in most languages.

Unless they have a two-way association?

Ofcz For now it doesn't make so much difference... but as the number of lessons grow It might become quite unsustainable to maintain and even makes it more likely to create impure components.

What do you think?

Heracraft commented 3 months ago

True, I was thinking within the next 4 days

On Mon, Jul 22, 2024 at 12:05 AM Ignas XV @.***> wrote:

simply why? we'll import the components the same way so why?

It's a good convention to separate Objects (in this case components) into their own separate files -at least in most languages.

Unless they have a two-way association?

Ofcz For now it doesn't make so much difference... but as the number of lessons grow It might become quite unsustainable to maintain and even makes it more likely to create impure components.

What do you think?

— Reply to this email directly, view it on GitHub https://github.com/ignasxv/master-of-education/issues/39#issuecomment-2241773892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP6BBXLALOPSQ6UFUUXPRQDZNQPBBAVCNFSM6AAAAABLHEMXA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRG43TGOBZGI . You are receiving this because you were assigned.Message ID: @.***>

ignasxvv commented 3 months ago

Greatyi greatyi, you can put this issue on hold then... and we will revisit it when it's necessary 🍻