search

ignatenkobrain / gnome-news

GNU General Public License v3.0
19 stars 7 forks source link

polish the FeedView design to match the mockups #27

Closed felipeborges closed 9 years ago

felipeborges commented 9 years ago

make the feed view look like the mockups.

screenshot preview screenshot from 2015-07-20 13-06-24

ignatenkobrain commented 9 years ago

Why 600px? I think we should get attributes from WebKit. @garnacho said about this today. There are viewport_width or something like this

vrutkovs commented 9 years ago

I don't like 'width: 600px' either - I guess one should be free to resize to any size which looks comfortable.

Otherwise - +1

felipeborges commented 9 years ago

neither do I, actually, but it matches the mockups. https://wiki.gnome.org/Design/Apps/Potential/News#Tentative_Design

vrutkovs commented 9 years ago

@allanday Should we limit the width of post view to 600px?

allanday commented 9 years ago

The screenshot looks pretty good to me. The main thing is to ensure that lines of text aren't uncomfortably long. The usual rule of thumb is that each line should be around 12 words in length.

felipeborges commented 9 years ago

the 600px width come up from wordpress themes I checked.

vrutkovs commented 9 years ago

The gods have spoken!

The main thing is to ensure that lines of text aren't uncomfortably long

Makes sense to me. Anyway, this is an internal CSS and doesn't affect feeds - we can change this anytime.

@ignatenkobrain, +1 from me, please merge if you don't mind

ignatenkobrain commented 9 years ago

Only one issue that no text xalign. now it's align to center, which makes me unhappy.

ignatenkobrain commented 9 years ago

oops, it looks like a bug in one of feeds. we can workaround this in the future