ignatenkobrain / gnome-news

GNU General Public License v3.0
19 stars 7 forks source link

Be more careful about what gets opened in new windows #49

Closed mcatanzaro closed 9 years ago

mcatanzaro commented 9 years ago

Only open the resource in a new window if the navigation type was NavigationType.LINK_CLICKED.

Also, do not assume that the WebKitPolicyDecision has a get_request() method. That's true for both WebKitNavigationPolicyDecision and WebKitResponsePolicyDecision, the implementations of WebKitPolicyDecision that exist today, but it might not be true of future WebKitPolicyDecisions.

ignatenkobrain commented 9 years ago

Thanks! merged ;)