search

ignatenkobrain / gnome-news

GNU General Public License v3.0
20 stars 7 forks source link

tracker.py: Avoid duplication of queries #86

Closed felipeborges closed 8 years ago

felipeborges commented 8 years ago

see #48

ignatenkobrain commented 8 years ago

It's not good. nco:emailAddress(?email) will just not work if it will not get last part. (WHERE part)

felipeborges commented 8 years ago

updated.

for reference: https://github.com/GNOME/gnome-documents/blob/master/src/query.js#L79

ignatenkobrain commented 8 years ago

and in general please use

"""something
{
%s
}""" % self._build_query()

instead of using + operator.

vrutkovs commented 8 years ago

LGTM. @ignatenkobrain, please merge if no other issues spotted in latest version

ignatenkobrain commented 8 years ago

LGTM