search

ignatov / intellij-erlang

Erlang IDE
https://www.jetbrains.com/help/idea/2018.2/getting-started-with-erlang.html
Other
735 stars 120 forks source link

Add otp-25 support #988

Closed zyuyou closed 1 year ago

zyuyou commented 2 years ago
  1. Add otp-25 maybe_expr support. #970
  2. Fix "Setup SDK" suggests. #977
  3. Fix rebar version check. #903
kvakvs commented 2 years ago

Code looks good Also fixes one bug which i tried to fix myself, in an experimental branch (Setup SDK button I'll give it a try soon

kvakvs commented 1 year ago

I am now running it with my work project for testing. Will report later. Cannot build release due to 4 failed tests (i can skip tests too but they should be fixed for merge) Screenshot 2022-12-08 at 07 29 27

zyuyou commented 1 year ago

I am now running it with my work project for testing. Will report later. Cannot build release due to 4 failed tests (i can skip tests too but they should be fixed for merge) Screenshot 2022-12-08 at 07 29 27

ok, I will check it out.

zyuyou commented 1 year ago

@kvakvs it's ok now

kvakvs commented 1 year ago

Reviewed it twice and running it now, too. Great job, thank you. Will merge soon.