to_s implementation for season and colour

[Oneill38]

Fixes #17

In response to your question, yes the ruby way to go about doing this is to override the to_s method on the model. Here we reuse the name method that's already been implemented.

[igneus]

Hi @Oneill38 , thanks for this PR! Travis CI reports fail, because the specs are locale-dependent. To check yourself, you can run them with all supported locales using rake spec_all_locales.

There are two ways to handle this:

• change matcher eq to custom matcher have_translation (for a selected locale - English by default - checks for equality, for the others it checks only that the string is properly translated)
• lock the test in question to a particular locale using I18n.with_locale

Examples of both ways can be found throughout the existing specs.

Apart of this the code is perfect, but before eventually merging, I would like to clear some conceptual concerns. I will address those in #17 . It may take some time, as I would like to hear opinions of other contributors, too.

[igneus]

Actually, one tiny style issue: when aliasing methods, it's preferable to use alias over defining a new method calling the old one.

[igneus]

Hi @Oneill38 , an update: at ruby-talk I have received some very reasonable feedback and I would like to have #to_s of those three classes changed in the way suggested there.

Would you mind changing the return values accordingly?

[igneus]

Closing as inactive. Feel free to reopen should you wish to continue it later.