creates day.weekday_name for human-readable weekday

igneus / calendarium-romanum

liturgical calendar library (Roman Catholic, post-Vatican II)

50 stars 21 forks source link

creates day.weekday_name for human-readable weekday #39

Closed RonWalker22 closed 6 years ago

igneus commented 6 years ago

Hi, thank you very much! This is an almost perfect implementation of #34 , the only missing bit is internationalization. Would you add it? The weekday names in all currently supported languages are already prepared (see config/locales).

RonWalker22 commented 6 years ago

Ok. I will add it.

RonWalker22 commented 6 years ago

I will review the failed test and update accordingly

igneus commented 6 years ago

Everything fixed before I could finish the review :smile: :+1: Thank you very much. Merging.

Closes #34