Include primary celebrations in CLI output

igneus / calendarium-romanum

liturgical calendar library (Roman Catholic, post-Vatican II)

50 stars 21 forks source link

Include primary celebrations in CLI output #48

Closed mkasberg closed 4 years ago

mkasberg commented 4 years ago

Primary and triduum celebrations were not being printed in CLI output because they did not have a short description for their rank.

Before:

$ bundle exec calendariumrom query 2018-12-25
2018-12-25
season: Christmas Season

After:

$ bundle exec calendariumrom query 2018-12-25
2018-12-25
season: Christmas Season

Christmas

igneus commented 4 years ago

Thanks for (spotting and) fixing this. May I ask you to provide a spec for the new behavior in spec/cli_spec.rb?

mkasberg commented 4 years ago

Pushed up an amended commit which includes a new spec. I tried to match the format of the existing specs.

As-is, there's no "label" on the left for these celebrations (like season:). Would you prefer to include a label somehow, or do you think it's OK as-is?

igneus commented 4 years ago

Thank you very much, it's OK as is. Merging.