search

igneus / calendarium-romanum

liturgical calendar library (Roman Catholic, post-Vatican II)
50 stars 21 forks source link

French translation improvement #5

Closed AzariasB closed 6 years ago

AzariasB commented 6 years ago

This one is on me, but I don't know how to do it : In English, when counting the week's numbers for example, you add a "th" (or "st" for first "nd" for second and "rd" for third). In french, there is the same thing : "er" for the first ("premier" in french) and ("eme" for the others). There is also a really special case : when there are only two elements, you say "second" (2nd) and not "deuxieme"(2eme). But I don't know if this is feasible.

igneus commented 6 years ago

But I don't know if this is feasible.

Yes, it is. Here is the class building ordinals https://github.com/igneus/calendarium-romanum/blob/master/lib/calendarium-romanum/ordinalizer.rb and here the specs https://github.com/igneus/calendarium-romanum/blob/master/spec/ordinalizer_spec.rb

igneus commented 6 years ago

@AzariasB Would you review the PR?

I think the special case "2nd" doesn't apply in the liturgical calendar, as we only use the ordinals for weeks of liturgical seasons and each of them has more than two weeks. The sole exception is the Christmas time. Can you check how the "2nd Sunday after Christmas" is spelled in official French liturgical calendars?

igneus commented 6 years ago

(The second Sunday after Christmas is quite a rare liturgical day, so even tracking down it's "official" French name may be complicated. It appeared e.g. in liturgical year 2013/14, on the 5th January 2014.)

AzariasB commented 6 years ago

Thanks for the links, I will review the PR :)

igneus commented 6 years ago

Closing. Reopen if necessary.