igneus / gly

flexible Gregorian notation format compiling to canonical gabc
6 stars 1 forks source link

Add option to specify output directory. #7

Open sundus-y opened 5 years ago

sundus-y commented 5 years ago
sundus-y commented 5 years ago

Solve issue #3

igneus commented 5 years ago

Hi, thank you very much!

Looks good overall, but I guess you didn't try to actually execute gly preview with the new option: currently PreviewBuilder knows nothing about the non-default output directory, so it will still attempt to execute gregorio and lualatex in the default location.

If you have gregorio and lualatex installed (or can have them easily), please try and fix this. If you can't, please remove all changes related only to gly preview - it is valuable enough to have the option even only for gly gabc and gly ly for now.

sundus-y commented 5 years ago

@igneus I wasn't able to install gregorio and lualatex but I think I have fixed the problem. Please help me test it. If it's still broken I will remove the -d option from the gly preview command.

igneus commented 5 years ago

Thanks. gly preview still fails. Or better: (lua)latex executed by gly fails. The problem is latex resolves include paths relative to the "current working directory", but include paths in the main .tex document generated by gly are relative to the document location. Preferable solution would be to run the lualatex process with "current working directory" in the output directory.

sundus-y commented 5 years ago

@igneus One last change, please test this and let me know if there is still a problem. I'm very hopeful this will fix it.

sundus-y commented 5 years ago

@igneus Did my last commit fix the issue?

igneus commented 5 years ago

I'm sorry, haven't got to testing it yet. But it's either fixed or there's some really tiny bit missing. I hope you won't mind if I simply merge and supply the eventual missing bit myself afterwards. Since you cannot test with the complete tooling, it would make no sense to request further changes from you. I hope to get to this in the near future.

sundus-y commented 5 years ago

@igneus Sounds good to me.