search

igniphp / framework

Swoole, PSR-15, PSR-7, PSR-11 lightweight modular anti-framework for REST micro-services.
MIT License
265 stars 14 forks source link

Expose settings property on server object #9

Closed smalot closed 6 years ago

smalot commented 6 years ago

This is useful if you want to manipulate settings in a server listener for example to write a message when the server starts:

Server listening on 8080

dkraczkowski commented 6 years ago

@smalot Hello, thanks for your input. Could you please add missin return typehint?

smalot commented 6 years ago

return typehint added.

I made another update according to the issue I created. If you prefer another MR I can split them

smalot commented 6 years ago

Travis job error seems not to be linked with my code ...

dkraczkowski commented 6 years ago

@smalot I have restarted travis job - seems OK now.