ignism / nucleus-dark-ui

Atom UI theme
MIT License
112 stars 34 forks source link

Can you use relative font-size? #69

Closed zhaocai closed 8 years ago

zhaocai commented 8 years ago

Fixed px size does not work with different settings.

Example

.inset-panel .panel-heading,
    .panel-heading {
      .text(heading);
      font-size: 24px;
      border-radius: 0;
ignism commented 8 years ago

Hey! could you elaborate where this is a problem?

zhaocai commented 8 years ago

Below are two screenshots to demonstrate

1.font-size: 24px : Fixed font-size 2.font-size: 0.9rem Relative font-size

The panel-heading is for atom-script. Check the icon size on the right side, you can see that the font-size is too big.

In fact, using fixed font-size assumes the base font-size to be the default 14px. What if some one uses 9px or 18px as default, fixed font-size would make the theme looks disproportional.

ignism commented 8 years ago

thanks! I will implement this in the next patch.

zhaocai commented 8 years ago

Thanks. Great Theme!

One more suggestion, the wrap-guide looks too distinctive. Try if you like the style below.

.wrap-guide {
  background-color: lighten( @base-background-color, 5% );
}