feat: plugin code and import from cli

ignite / cli-plugin-network

Apache License 2.0

8 stars 9 forks source link

feat: plugin code and import from cli #1

Closed tbruyelle closed 1 year ago

tbruyelle commented 2 years ago

This PR imports the network code from CLI with a couple of changes :

new command network tool proxy-tunnel that replaces the start-with-tunneling-command (removed from scaffolded chain)
adapt network chain prepare to call network tool proxy-tunnel before appd start.
ignitecmd package renamed to cmd
import StartProxyForTunneledPeers from CLI

To use this plugin, just compile ignite from https://github.com/ignite/cli/pull/3306 and run ignite network.

The code has been updated regularly thanks to patches, so it should be up-to-date with CLI/main but it's better to have a closer look on that.

jeronimoalbi commented 1 year ago

LGTM, I will wait for the comments to be resolved before approving 👍

aljo242 commented 1 year ago

Good to merge! nice

tbruyelle commented 1 year ago

If possible, it's better to merge https://github.com/ignite/cli/pull/3306 first because then we can use a hash from cli@main in the plugin go.mod.

tbruyelle commented 1 year ago

If possible, it's better to merge ignite/cli#3306 first because then we can use a hash from cli@main in the plugin go.mod.

Forget about that, we'll have to set the plugin version also in cli, and we have to do that after the merge of this PR, so let's do that first.

francas commented 1 year ago

import StartProxyForTunneledPeers from CLI

Hi, is this advice valid? I tried to search both in cli and cli-plugin-network repos for StartProxyForTunneledPeers in the codebase but it can't be found anywhere.

I'm upgrading ignite/cli from 25->26 and not sure what to do with network.StartProxyForTunneledPeers in a scaffolded app given that github.com/ignite/cli/ignite/services/network is removed.