ignite / cli

Ignite is a CLI tool and hub designed for constructing Proof of Stake Blockchains rooted in Cosmos-SDK
https://ignite.com
Other
1.24k stars 536 forks source link

More resilient app.go modification process for the scaffolder #1324

Open lumtis opened 3 years ago

lumtis commented 3 years ago

Is your feature request related to a problem? Please describe. Modification in app.go depends on variables with an assumed name: app (most important), keys, appCodec, etc... Those variables names can be modified, this would make the scaffolding process generating an invalid app

Describe the solution you'd like We must extend the cosmosanalysis package feature set and implement methods to detect structure instantiation and detect variable names. If inconsistencies are detected, we make skip the app modification

Describe alternatives you've considered We must at least detect if some variable names are used and skip app modification, we should prevent generating an app that doesn't compile

salmad3 commented 4 months ago

Need to investigate further criteria for resilient app.go, beyond name detection and structure instantiation.