ignite / cli

Ignite is a CLI tool and hub designed for constructing Proof of Stake Blockchains rooted in Cosmos-SDK
https://ignite.com
Other
1.25k stars 546 forks source link

create awesome 404 page for Starport docs #1610

Closed barriebyron closed 2 years ago

barriebyron commented 2 years ago

Is your feature request related to a problem? Please describe. our current Starport docs 404 page is bland and does not encourage continued action:

Page Not Found The page you visited either does not exist or has been moved. We're sorry for the inconvenience. Back to home

Broken doc links happen for a variety of reasons: docs have moved, topics change or are removed. Legacy doc links are out in the universe. Users have bookmarked stale links and might be holding on to older resources.

Describe the solution you'd like

For inspiration, https://designshack.net/articles/inspiration/what-makes-a-great-404-error-page/

I like the selection of versions and products on this 404 page (docs at one of my former jobs) https://docs.datastax.com/en/dsdesktop/doc/desktop/dsDesktopAbut.html

Good humor on https://www.pixar.com/feature-films-lanch

Good theme on https://www.netflix.com/NotFound?prev=https%3A%2F%2Fwww.netflix.com%2F432

I like the graphics and fun on https://business.twitter.com/en/resources/twitter-marketing-calendar/us.html but this sample 404 page still needs at least one link to continue exploring

Joeycicc commented 2 years ago

I'd love to help with this!! I wanna participate in the codefest and this is perfect!!!

soniasingla commented 2 years ago

@Joeycicc feel free to raise pull request with your solution.

rksingh2001 commented 2 years ago

Can I take up this issue if no one is working on it?

barriebyron commented 2 years ago

I don't see a PR from @Joeycicc ... so it's likely that this work is not yet picked up, so have a go at it @rksingh2001

barriebyron commented 2 years ago

if there is mutual interest, perhaps you two can help each other!?

rksingh2001 commented 2 years ago

It looks to me that the Error 404 page for the Starport Docs is being loaded from another dependency https://github.com/cosmos/vuepress-theme-cosmos in https://github.com/cosmos/vuepress-theme-cosmos/blob/develop/layouts/NotFound.vue I can't figure out how will I edit this page from this repository, will I need to make a PR to the other theme repository or is there a way to override the Error 404 page from this repository only? @barriebyron

barriebyron commented 2 years ago

feel free to raise a PR on the repository that will trigger the 404, thanks for finding the right code @rksingh2001

rksingh2001 commented 2 years ago

Ok, Do I need to create issue there or make a PR directly once it's done? @barriebyron and will it be counted in codefest?

barriebyron commented 2 years ago

hi @rksingh2001 let's keep this one because I was able to put the codefest label on it, and also use https://github.com/cosmos/vuepress-theme-cosmos/issues/289 for the dependency work

have fun with the 404 page, we really really need it! thank you

rksingh2001 commented 2 years ago

I have made the Pull Request on the dependency cosmos/vuepress-theme-cosmos#289 @barriebyron

rksingh2001 commented 2 years ago

@barriebyron @soniasingla The Pull request is merged, I think someone, the owner of the npm account ( https://www.npmjs.com/package/vuepress-theme-cosmos ) need to publish the newer version so that it can be updated on the website.

soniasingla commented 2 years ago

@darika-dev can you check the request and make necessary updates if required? :)

rksingh2001 commented 2 years ago

I think this issue can be closed @barriebyron as vuepress-theme-cosmos will be changed, and until then it's not possible to work on this issue.

barriebyron commented 2 years ago

thanks for being a part of our community @rksingh2001 and keeping up with the status of this issue.