search

ignite / cli

Ignite is a CLI tool and hub designed for constructing Proof of Stake Blockchains rooted in Cosmos-SDK
https://ignite.com
Other
1.26k stars 547 forks source link

tendermint/starport/actions/cli@<version> uses latest develop branch #2080

Open 7AC opened 2 years ago

7AC commented 2 years ago

Describe the bug I'm trying to use the cli action at the version appropriate for my SDK, based on:

https://github.com/tendermint/starport#cosmos-sdk-compatibility

Looks like the action version has no effect since the Dockerfile always picks up HEAD from the develop branch:

https://github.com/tendermint/starport/blob/v0.19.3/actions/cli/Dockerfile

To Reproduce Have the following in a workflow:

        uses: tendermint/starport/actions/cli@v0.19.2
7AC commented 2 years ago

I'd be happy to send a PR for this but I think the fix is actually doing something like this every time you release, so I'm not sure it's something we can help with on our end:

diff --git a/actions/cli/Dockerfile b/actions/cli/Dockerfile
index eccbc382..573b65ba 100644
--- a/actions/cli/Dockerfile
+++ b/actions/cli/Dockerfile
@@ -1,3 +1,3 @@
-FROM ignitehq/cli:develop
+FROM ignitehq/cli:v0.24.0

 USER root

The issue with keeping a mutable develop tag there is we can't have reproducible builds using the action.