search

ignite / cli

Ignite is a CLI tool and hub designed for constructing Proof of Stake Blockchains rooted in Cosmos-SDK
https://ignite.com
Other
1.26k stars 549 forks source link

feat: Add multi node (validator) testnet #4377

Closed likesToEatFish closed 2 weeks ago

likesToEatFish commented 1 month ago

Closes: #4374

This PR added the feature to ignite multi-node testnet.

Test steps:

  1. ignite scaffold chain github.com/test/mychain
  2. cd mychain
  3. go install ./...
  4. ignite testnet multi-node

The interface looks like this:

image
likesToEatFish commented 1 month ago

The feature is done, but the documentation hasn't been written yet. I plan to complete it tomorrow.

julienrbrt commented 1 month ago

Hey, we've changed a bit the requirements and simplified the config.yaml: https://github.com/ignite/cli/issues/4374#issuecomment-2386058282

In short, we should use the existing validators section for multi-node. We should add a comments that says the fist validator is used in chain serve and all validators are used in testnet multi-node. For random, less not have them in the config.yaml anymore, but just let multi-node take a flag.

likesToEatFish commented 1 month ago

Here is the new display result, there will be 5 daemon lines for each node:

image
likesToEatFish commented 1 month ago

we should use the existing validators section for multi-node.

And I modified the use of the existing validators section for multi-node.

Pantani commented 1 month ago

@likesToEatFish can you change the command so we can use the chain serve instead of the new multi-node command

https://github.com/ignite/cli/issues/4374#issuecomment-2383475390

likesToEatFish commented 1 month ago

@likesToEatFish can you change the command so we can use the chain serve instead of the new multi-node command

#4374 (comment)

I added in vaildators

image
julienrbrt commented 1 month ago

@likesToEatFish can you change the command so we can use the chain serve instead of the new multi-node command

https://github.com/ignite/cli/issues/4374#issuecomment-2383475390

I don't think it should use chain serve. The validator field makes sense but chain serve should be imho for a single validator.

likesToEatFish commented 1 month ago

I added color to the console screen @julienrbrt , it looks like this:

image
julienrbrt commented 1 month ago

Thanks! Are you able to add a sort a menu/status bar to quit a node easily? So that it has a real TUI feeling

julienrbrt commented 1 month ago

Just as a way to tell/let the user how to kill/restart a node easily. Then I think it's good to go 👍

likesToEatFish commented 1 month ago

do you mean it looks like this:

image
Pantani commented 1 month ago

@likesToEatFish any thought about it? Why did you marked as solved?

https://github.com/ignite/cli/pull/4377#discussion_r1797366160

likesToEatFish commented 1 month ago

@likesToEatFishBạn có suy nghĩ gì về vấn đề này không? Tại sao bạn đánh dấu là đã giải quyết?

#4377 (bình luận)

Sorry, I replied but for some reason it is pending

image
likesToEatFish commented 1 month ago

I apologize for the many comments I've provided that are still pending. I didn't notice their status, which serves as a lesson for me to stay more attentive in the future.

likesToEatFish commented 1 month ago

Thanks @julienrbrt @Pantani , I learned a lot of new things from this PR! 🙏🏾

likesToEatFish commented 3 weeks ago

Hi @julienrbrt @Pantani , I noticed the PR received positive feedback a few days ago but hasn't been merged yet. If there's anything further needed from my side or any blockers, please let me know. Thanks!

julienrbrt commented 2 weeks ago

Hey! I'll be reviewing this today! Sorry about the delay (cosmoverse + holidays :D)