search

ignite / cli

Ignite is a CLI tool and hub designed for constructing Proof of Stake Blockchains rooted in Cosmos-SDK
https://ignite.com
Other
1.26k stars 549 forks source link

feat: integrate with v0.52.x (2/n) #4423

Open julienrbrt opened 14 hours ago

julienrbrt commented 14 hours ago

Follow-up of https://github.com/ignite/cli/pull/4289

The previous PR implemented the required changes for the app and the minimum changes for the modules.

The follow-up will do the two remaining tasks:

While the modules are working fine currently for 0.52, this bring them to the latest recommendations. The changes allows to make modules simpler, and baseapp and v2 compatible.

Pantani commented 7 hours ago

@julienrbrt the export genesis command is not working

[IGNITE] error exporting state: genesis export error in mars: collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/mars.mars.v1.Bla
Pantani commented 7 hours ago

besides the genesis export command, everything is ok for me

Pantani commented 6 hours ago

The app/export.go file still has sdk.Context declaration and sdk.ValAddressFromBech32(addr) decode. Do you know if we have plans to cover the refactor later?

Pantani commented 6 hours ago

I also got some unhandled errors not in this PR. In the cmd/chaind/cmd/testnet.go there is a block:

app.DistrKeeper.ValidatorHistoricalRewards.Set(ctx, collections.Join(sdk.ValAddress(validator), uint64(0)), distrtypes.NewValidatorHistoricalRewards(sdk.DecCoins{}, 1))
app.DistrKeeper.ValidatorCurrentRewards.Set(ctx, validator, distrtypes.NewValidatorCurrentRewards(sdk.DecCoins{}, 1))
app.DistrKeeper.ValidatorsAccumulatedCommission.Set(ctx, validator, distrtypes.InitialValidatorAccumulatedCommission())
app.DistrKeeper.ValidatorOutstandingRewards.Set(ctx, validator, distrtypes.ValidatorOutstandingRewards{Rewards: sdk.DecCoins{}})

and deprecated addresses decode in this file also

Pantani commented 6 hours ago

Maybe we should avoid scaffolding NewWeightedProposalMsg method into the x/chain/module/simulation.go file

Pantani commented 6 hours ago

we need refactor the FindAccount method from x/module/simulation/helpers.go

Pantani commented 6 hours ago

wdyt remove the ErrSample from x/module/types/errors.go

Pantani commented 6 hours ago

I tried to review the PR but have been having issues because there are many files and too many plush files chance. So, I scaffolded a chain and some types so I could check all the codes and change, and these are all my suggestions; I think we don't need to solve everything in this PR. We can open issues to solve later and before the v29. wdyt?