search

ignited / omnipay-zippay

MIT License
1 stars 2 forks source link

Starting: Omnipay 2.0 Support #2

Closed sudiptpa closed 5 years ago

sudiptpa commented 5 years ago

@dcon138 Do you have a little bit of time to help me with fixing tests? Same thing goes green with the Omnipay v3 branch. I am needing this package for my Laravel v4.2 project, please help if possible.

dcon138 commented 5 years ago

Hi @sudiptpa,

I would be happy to take a look at it, though I won't be able to do so immediately as we don't actively develop this package.

I'll have a look at it when time comes up to do so. If this is an urgent priority for you, i'd recommend perhaps attempting to get it working without waiting on my availability.

sudiptpa commented 5 years ago

Hi @dcon138,

I have pushed the working code for Omnipay v2.0 support. I have worked on local with symlink via composer and my integration for my project is working perfectly.

Error Tip: The tests having Mock with error code 4xx are failing, guzzle treating those mock as Bad Request and throwing exception instead of response.

The same tests working for v3.0 support in the master branch of this package, i guess this is error with guzzle version or something. Would you mind if i ask you to have a look at that for me?

For now, i will use the commit point to pull the code for my production, i will update my project later when you release a new tag. Also i will try my best to fix the tests if possible so it will be eligible to merge and tag a new release.

Many Thanks for building this package, it really saved my time.