search

ignited / omnipay-zippay

MIT License
1 stars 2 forks source link

Updated the AbstractRequest to allow negative amounts so that discounts can be applied #5

Closed simonworkhouse closed 4 years ago

simonworkhouse commented 4 years ago

Not sure if you would prefer this to be in the AbstractRequest or set only for specific requests, but Zip Pay requires discounts to be provided with a negative amount which will fail if negative amounts are not allowed.

simonworkhouse commented 4 years ago

I have created this as a draft pull request in case it would be preferred for the $negativeAmountAllowed parameter to be configured for specific requests rather than in the AbstractRequest. Please provide feedback so that this pull request can be marked as ready for review.

alexw23 commented 4 years ago

Thanks @simonworkhouse, given this is what the PayPal driver also has in it's implementation I don't see the harm.

Feel free to open this PR.

simonworkhouse commented 4 years ago

Excellent, thank you.