igniterealtime / openfire-hazelcast-plugin

Adds support for running multiple redundant Openfire servers together in a cluster
10 stars 13 forks source link

Broken dependency fix #48

Closed BuDDi closed 4 years ago

guusdk commented 4 years ago

Thank you for your contribution. However: I don't think it's appropriate to merge the fork, which seems to be a deliberate fork, into this project.

Even if that is the intention, I have strong reservations against keeping a third-party binary maven artifact as part of the source code. There's not telling what's in there. Also, I can't tell how this would affect regular users. The accompanying text states that it is needed to pin the version of Hazelcast that's used to a specific version, which I'd also like to avoid in this plugin. Finally, there appears to be a conflict.