search

igniterealtime / openfire-hazelcast-plugin

Adds support for running multiple redundant Openfire servers together in a cluster
10 stars 12 forks source link

Warn against usage of plugin-provided classes in Hazelcast #74

Closed guusdk closed 2 years ago

guusdk commented 2 years ago

See https://github.com/igniterealtime/openfire-monitoring-plugin/issues/155 This links eventually to https://github.com/guusdk/openfire-pushnotification-plugin/commit/48b408ca233f812c57ccf1316ce9441f521cc630

Caching custom instances has ClassLoader problems when reloading plugins in a cluster.

Raise a warning every time we see (the first?) instance of a class loaded by a PluginClassLoader being added to a cache.

Ideally, if there's a reflection or something we can go at boot time, that'd be better.

If there's something we can add as a deprecation, or a plugin compile-time warning, better still.

(Separate tickets required to fix this in our plugins)

This issue was previously known as https://igniterealtime.atlassian.net/browse/OF-2238

guusdk commented 2 years ago

https://github.com/igniterealtime/openfire-monitoring-plugin/pull/156#issuecomment-759551476 suggests that a similar issue exists with executable tasks. Lets put in place a similar warning for those.