search

igniterealtime / openfire-inverse-plugin

Adds inVerse web client to Openfire
Apache License 2.0
3 stars 7 forks source link

Issues with inVerse downloads #4

Closed wrooot closed 5 years ago

wrooot commented 5 years ago

Downloads page still shows 4.0.2 as latest. Also, snapshots downloads are broken.

_Originally posted by @wrooot in https://github.com/igniterealtime/openfire-inverse-plugin/issue_comments#issuecomment-451944293_

guusdk commented 5 years ago

@GregDThomas - the version of this plugin has a weird format, that appears to clash with the new SNAPSHOT/timestamp detection code introduced in https://github.com/igniterealtime/IgniteRealtime-Website/commit/163f7ac69ece9de16014848c5c25b89f88d4031d. Do you have time to have a look?

GregDThomas commented 5 years ago

Looking now ...

GregDThomas commented 5 years ago

I think https://github.com/igniterealtime/IgniteRealtime-Website/pull/92 fixes it

wrooot commented 5 years ago

Yep, snapshots are fixed now. But what about the latest release? 4.0.2 is old one.

GregDThomas commented 5 years ago

The plugin downloads page reflects what's in Archiva; https://www.igniterealtime.org/archiva/#artifact/org.igniterealtime.openfire.plugins/inverse - there may be missing artefacts from there.

wrooot commented 5 years ago

I'm referring this PR https://github.com/igniterealtime/openfire-inverse-plugin/pull/3 which is merged, so i figured new version of plugin should be released (or maybe not, and it is waiting for more changes). There is 4.0.4 snapshot of inVerse, but no official release. Maybe Guus hasn't copied it to Archiva (4.0.4 snapshot is there).

GregDThomas commented 5 years ago

Unfortunately this is another case where the version in the pom.xml (4.0.6-release-1-SNAPSHOT) doesn't match the plugin.xml (4.0.6 Release 1). It's the version in the pom.xml that decides the release status.

(i.e. version 4.0.6 Release 1 of this plugin has yet to be released)

wrooot commented 5 years ago

I wasn't sure if Converse version should always match inVerse. But maybe you are right and it should be 4.0.6 instead. I wonder what is the release process then or is Guus waiting for more changes to include before releasing 4.0.6.

guusdk commented 5 years ago

Proposed fix in https://github.com/igniterealtime/openfire-inverse-plugin/pull/5