search

igniterealtime / openfire-mucextinfo-plugin

An Openfire plugin that allows an admin to configure Extended Service Discovery information to Multi User Chat entities.
2 stars 5 forks source link

Rename DataForm class to avoid conflicts #7

Closed guusdk closed 4 years ago

guusdk commented 4 years ago

This plugin introduces a new class, org.igniterealtime.openfire.plugin.mucextinfo.DataForm. The simple name of this class clashes with implementations that are provided by Openfire: org.jivesoftware.openfire.forms.DataForm and org.xmpp.forms.DataForm.

During development, I have seen ClassCastExceptions pop up, that indicate that Openfire is trying to cast the class from this plugin to one of the variants provided by Openfire. What I think is going on, is that when this plugin gets unloaded and reloaded, references get mangled.

To avoid confusion, the DataForm class in this plugin should be renamed.

guusdk commented 4 years ago

Although this change was applied, it turned out to be unnecessary. The cause for the ClassCastExceptions is tracked in #8.